Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 3038 incorrect machine #63

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Eng 3038 incorrect machine #63

merged 5 commits into from
Dec 8, 2023

Conversation

ankitintg
Copy link
Contributor

This PR is created to resolve empty responses when using non-existing machine to get_kpi_for_asset.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f80e915) 66.34% compared to head (3185c8d) 66.50%.

Files Patch % Lines
smsdk/ma_session.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   66.34%   66.50%   +0.16%     
==========================================
  Files          27       27              
  Lines        2065     2066       +1     
  Branches      428      428              
==========================================
+ Hits         1370     1374       +4     
+ Misses        560      557       -3     
  Partials      135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrnthv mrnthv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ankitintg ankitintg merged commit 4c42e54 into master Dec 8, 2023
6 checks passed
Copy link
Contributor

@mrnthv mrnthv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants